This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-1032] Adding WSCG check for keys in Join #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackylee-ch indeed a missing check, thanks for the patch! |
zhouyuan
reviewed
Jul 20, 2022
...ve-sql-engine/core/src/main/scala/com/intel/oap/execution/ColumnarShuffledHashJoinExec.scala
Outdated
Show resolved
Hide resolved
PHILO-HE
reviewed
Jul 20, 2022
...ve-sql-engine/core/src/main/scala/com/intel/oap/execution/ColumnarShuffledHashJoinExec.scala
Outdated
Show resolved
Hide resolved
|
The patch looks good to me. +1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We do a WSCG check in ColumnarShuffledHashJoinExec. But only check the condition, not leftKeys and rightKeys check.
For ExsitingJoin, the condition is null, and there are only leftKeys and rightKeys, which leads to function is currently not supported in WSCG.
How was this patch tested?
unit tests and manual test.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)